Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes comparison of layer metadata vs expected wrt deprecation_date #261

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

pivotal-david-osullivan
Copy link
Contributor

Summary

Related to #240 - truncates the deprecation_date when comparing layer metadata to expected metatdata. This fixes a bug where dependencies are downloaded every build regardless of a previous successful build with the same dependencies etc

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pivotal-david-osullivan pivotal-david-osullivan added type:bug A general bug semver:patch A change requiring a patch version bump labels Jun 27, 2023
@pivotal-david-osullivan pivotal-david-osullivan requested a review from a team as a code owner June 27, 2023 13:37
@pivotal-david-osullivan pivotal-david-osullivan merged commit 42d0fff into main Jun 29, 2023
3 checks passed
@pivotal-david-osullivan pivotal-david-osullivan deleted the layer-metadata-fix branch June 29, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants